Open
Conversation
Bundles tcmu-runner,gluster-block, glusterfs in a single container. Signed-off-by: Vijay Bellur <vbellur@redhat.com>
|
Thanks a lot @vbellur ! This dockerfile looks good to me, the only pending is an updated README as we have it for S3 and Server container. .Also, iic, Ashiq was testing this last week. I will get the result soon and merge. |
humblec
reviewed
Apr 28, 2017
gluster-block/Fedora/Dockerfile
Outdated
| RUN dnf config-manager --add-repo https://download.gluster.org/pub/gluster/gluster-block/gluster-block.repo | ||
| RUN dnf install -y gluster-block | ||
|
|
||
| RUN echo 'root:password' | chpasswd |
There was a problem hiding this comment.
Please remove this line. We dont have to configure this passwd, there is a security risk involved.
There was a problem hiding this comment.
@vbellur can you please address this comment ?
Member
Member
|
@vbellur If you had successfully built an image can to tar it and send/share it some way. |
Member
|
Re-triggering the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles tcmu-runner,gluster-block, glusterfs in a single container.
Signed-off-by: Vijay Bellur vbellur@redhat.com